Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde serialization and deserialization to Packet Receipt #794

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Add serde serialization and deserialization to Packet Receipt #794

merged 2 commits into from
Jul 31, 2023

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #XXX

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (17c42c3) 71.33% compared to head (a295255) 71.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   71.33%   71.32%   -0.01%     
==========================================
  Files         124      124              
  Lines       14828    14829       +1     
==========================================
  Hits        10577    10577              
- Misses       4251     4252       +1     
Files Changed Coverage Δ
crates/ibc/src/core/ics04_channel/packet.rs 47.87% <0.00%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit 9b9cbd0 into cosmos:main Jul 31, 2023
12 checks passed
@Farhad-Shabani Farhad-Shabani added this to the v0.43.1 milestone Jul 31, 2023
dzmitry-lahoda pushed a commit to dzmitry-lahoda-forks/ibc-rs that referenced this pull request Aug 1, 2023
…#794)

* Add serde serialization and deserialization to PacketMsgType

* Create 794-add-ser-der-for-packet-receipt.md
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Add serde serialization and deserialization to PacketMsgType

* Create 794-add-ser-der-for-packet-receipt.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants