Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate decoding-related errors into new DecodingError type #1325

Merged
merged 73 commits into from
Sep 9, 2024
Merged

Consolidate decoding-related errors into new DecodingError type #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
ad86a76
Define DecodingError in ibc-primitives
seanchen1991 Aug 26, 2024
7a2ee6e
Utilize DecodingError in ics721
seanchen1991 Aug 26, 2024
a48cec2
Start using DecodingError in ClientError
seanchen1991 Aug 26, 2024
1bc7034
Define StatusError type
seanchen1991 Aug 26, 2024
811d2d5
Wire up StatusError
seanchen1991 Aug 26, 2024
56105ad
Wiring up DecodingError
seanchen1991 Aug 27, 2024
fc52865
Add DecodingError to RouterError
seanchen1991 Aug 27, 2024
3bb4953
Remove unused From impl
seanchen1991 Aug 27, 2024
578dfc9
Change format of an import
seanchen1991 Aug 27, 2024
d3de049
Change format of an import
seanchen1991 Aug 27, 2024
164e0b9
Change format of an import
seanchen1991 Aug 27, 2024
c309f72
Move DecodingError into ics24
seanchen1991 Aug 27, 2024
ec37db2
Cargo nightly fmt
seanchen1991 Aug 28, 2024
6900bd9
Use DecodingError in more places
seanchen1991 Aug 28, 2024
452ad43
cargo fmt
seanchen1991 Aug 28, 2024
dcdd211
cargo fmt
seanchen1991 Aug 28, 2024
56c63de
Update cw-check Cargo.lock
seanchen1991 Aug 28, 2024
334f249
Add necessary wasm-client feature attribute
seanchen1991 Aug 28, 2024
2f179b6
Move InvalidUri error variant back to NftTransferError
seanchen1991 Aug 28, 2024
a64b377
Regenerate cw hcheck cargo.lock
seanchen1991 Aug 28, 2024
3a4d822
Add serde feature attribute
seanchen1991 Aug 28, 2024
fb4ceac
Remove ClientError::InvalidClientIdentifier error variant in favor of…
seanchen1991 Aug 29, 2024
4cd30ab
Add derive_more::From on NftTransferError
seanchen1991 Aug 29, 2024
494e23e
Stashing changes
seanchen1991 Aug 29, 2024
72217f4
Revert "Add derive_more::From on NftTransferError"
seanchen1991 Aug 29, 2024
a36b2d7
Remove RouterError::UnknownMessageTypeUrl
seanchen1991 Aug 29, 2024
9a776c8
Add derive_more::From on TokenTransferError
seanchen1991 Aug 29, 2024
023595c
Add derive_more to NftTransferError
seanchen1991 Aug 29, 2024
0341ebd
Remove tendermint-proto dependency from ibc-primitives
seanchen1991 Aug 29, 2024
6be11a0
Remove StatusError
seanchen1991 Aug 30, 2024
cc2e5c6
Remove unnecessary ClientError::Decoding wrappings
seanchen1991 Aug 30, 2024
43c17eb
Clean up TendermintClientError
seanchen1991 Aug 30, 2024
6913376
Regenerate cw-check cargo.lock
seanchen1991 Aug 30, 2024
e684b54
taplo fmt
seanchen1991 Aug 30, 2024
a74351d
Apply PR feedback
seanchen1991 Aug 30, 2024
98954a6
Use ibc_proto::Error type instead of tendermint_proto::Error
seanchen1991 Sep 3, 2024
60af754
Change FailedToParseType fields to make them more clear
seanchen1991 Sep 3, 2024
b449a43
Revert InvalidTrace and InvalidCoin TokenTransferError variants
seanchen1991 Sep 3, 2024
37cc896
Remove NftTransferError variants in favor of DecodingError::InvalidJson
seanchen1991 Sep 3, 2024
23dc6d3
cargo fmt
seanchen1991 Sep 3, 2024
35bb851
Regenerate cw-check cargo.lock
seanchen1991 Sep 3, 2024
c3caee1
Separate out error variants that need to be moved to host-relevant er…
seanchen1991 Sep 4, 2024
dc915da
Consolidate TendermintClientError decoding errors
seanchen1991 Sep 4, 2024
e74f4bf
Consolidate Connection and Packet decoding errors
seanchen1991 Sep 4, 2024
a814a3e
Remove WasmClientError
seanchen1991 Sep 4, 2024
810a5ad
Consolidate Identifier variant naming
seanchen1991 Sep 4, 2024
a307051
Remove HostError annotations in doc comments
seanchen1991 Sep 4, 2024
eb4e612
Consolidate CommitmentError variants
seanchen1991 Sep 5, 2024
a59e0de
Consolidate ConnectionError variants
seanchen1991 Sep 5, 2024
a324e76
Revert some CommitmentError variants
seanchen1991 Sep 5, 2024
5b37bd5
Change TryFrom<Any> for MsgEnvelope Error type to DecodingError
seanchen1991 Sep 5, 2024
bd0e5cf
Remove ConnectionError::Identifier variant in favor of DecodingError:…
seanchen1991 Sep 6, 2024
fba4f7b
Remove ChannelError::Identifier variant in favor of DecodingError::Id…
seanchen1991 Sep 6, 2024
c309dd2
Remove PacketError::Identifier variant in favor of DecodingError::Ide…
seanchen1991 Sep 6, 2024
9f26de7
Revert TokenTransferError FailedToDeserializeAck and FailedToDeserial…
seanchen1991 Sep 6, 2024
99c6c9e
Revert NftTransferError FailedToDeserializeAck and FailedToDeserializ…
seanchen1991 Sep 6, 2024
1106e5f
Revert ics20 and ics721 on_recv_packet_execute impls
seanchen1991 Sep 6, 2024
03a6d01
Remove additional Identifier error variants
seanchen1991 Sep 6, 2024
47562b4
Add TendermintClientError::InsufficientMisbehaviourHeaderHeight variant
seanchen1991 Sep 6, 2024
b7eb787
Implement From<IdentifierError> for ClientError and ConnectionError
seanchen1991 Sep 6, 2024
73a186e
Incorporate PR feedback
seanchen1991 Sep 6, 2024
2804e7a
Change TryFrom<RawConsensusState> for ConsensusState error to Decodin…
seanchen1991 Sep 6, 2024
39988c0
Remove RouterError::Decoding variant
seanchen1991 Sep 6, 2024
5c5dcbe
Revert AcknowledgementStatus tests
seanchen1991 Sep 6, 2024
9e51a6d
Cargo fmt
seanchen1991 Sep 6, 2024
4a2a8e7
Fix test_ack_de
seanchen1991 Sep 6, 2024
6fd057c
Fix typo in doc comment
seanchen1991 Sep 6, 2024
8f9193c
Fix test_ack_de
seanchen1991 Sep 6, 2024
4fd2432
Fix test_ack_de
seanchen1991 Sep 6, 2024
ad5268c
fix: revert nft721 on module errors
Farhad-Shabani Sep 9, 2024
04c7ad1
fix: remove Identifier variant from few more enums
Farhad-Shabani Sep 9, 2024
51cb3a4
fix: remove unused tendermint-proto dep
Farhad-Shabani Sep 9, 2024
96cc7bb
chore: update Cargo.lock
Farhad-Shabani Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ ibc-client-wasm-types = { version = "0.54.0", path = "./ibc-clients/ics08-
ibc-app-transfer-types = { version = "0.54.0", path = "./ibc-apps/ics20-transfer/types", default-features = false }
ibc-app-nft-transfer-types = { version = "0.54.0", path = "./ibc-apps/ics721-nft-transfer/types", default-features = false }

ibc-proto = { version = "0.47.0", default-features = false }
ibc-proto = { version = "0.47.1", default-features = false }

# cosmos dependencies
tendermint = { version = "0.38.0", default-features = false }
Expand Down
6 changes: 4 additions & 2 deletions ci/cw-check/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

87 changes: 45 additions & 42 deletions ci/no-std-check/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading