ci(release): enforce acyclic dep order during release #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to remove ibc-testkit dev-dependency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
+ Coverage 64.34% 64.39% +0.04%
==========================================
Files 229 229
Lines 22005 22017 +12
==========================================
+ Hits 14160 14178 +18
+ Misses 7845 7839 -6 ☔ View full report in Codecov by Sentry. |
rnbguy
force-pushed
the
rano/fix/acyclic-workspace-deps
branch
from
d04159e
to
35e12e0
Compare
rnbguy
changed the title
I think this makes sense. I think it's fine to not release |
seanchen1991
approved these changes
Apr 30, 2024
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* mv tendermint client cw tests to testkit this is to remove ibc-testkit dev-dependency * note for acyclic release order * test proto::Any json ser-der * nit * fix unused imports * cargo format * update releases process * Add more instructions on how to deal with cyclic dependencies --------- Co-authored-by: Sean Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
The latest release failed on CI because it tried to release
ibc-client-tendermint-cwbeforeibc-testkit. Butibc-client-tendermint-cwhas a dev-dependency toibc-testkit.It looks like it is an issue at
cargo-release, as it ignores dev-dependency edges.Important
The workspace crates must not depend on
ibc-testkit- as it depends onibc.Also, there is a question: should we release cosmwasm contracts on crates-io, e.g.
ibc-client-tendermint-cw, on crates-io? If not, we should exclude them incargo-releasecommand. Maybe we can compile and add the wasm blobs to release artifacts.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.