imp(core-host-types): add new storage paths #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
- Coverage 67.07% 66.78% -0.30%
==========================================
Files 204 204
Lines 20543 20473 -70
==========================================
- Hits 13780 13672 -108
- Misses 6763 6801 +38 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
requested changes
Feb 1, 2024
7 tasks
Farhad-Shabani
approved these changes
Feb 1, 2024
Farhad-Shabani
changed the title
Farhad-Shabani
changed the title
7 tasks
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add missing paths * update Path enum with new paths * update parse functions * add next_sequence path parser * add unit tests * update names and path format * update parsing functions * update tests * use rstest cases for Path::try_from * add comment in rstest * consistent with old tests * update rstest test names * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1065
Description
Adds the following paths in the ibc
Pathtype.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.