-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1 #3364
chore(deps): Bump github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1 #3364
Conversation
Bumps [github.com/cometbft/cometbft-db](https://github.com/cometbft/cometbft-db) from 0.12.0 to 1.0.1. - [Release notes](https://github.com/cometbft/cometbft-db/releases) - [Changelog](https://github.com/cometbft/cometbft-db/blob/main/CHANGELOG.md) - [Commits](cometbft/cometbft-db@v0.12.0...v1.0.1) --- updated-dependencies: - dependency-name: github.com/cometbft/cometbft-db dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter seems to get stuck (also locally). Also, the e2e tests are failing. The e2e error seems to be related to the go version:
#23 [gaiad-builder 10/13] RUN go mod download
#23 0.125 go: go.mod requires go >= 1.23.1 (running go 1.22.8; GOTOOLCHAIN=local)
#23 ERROR: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1
@@ -1,6 +1,8 @@ | |||
module github.com/cosmos/gaia/v21 | |||
|
|||
go 1.22.6 | |||
go 1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pebbledb requires go 1.23 or higher
IMO the correct way to handle this is to bring this in at the next routine upgrade.
That will ensure that all of the validators compile with go 1.23 (and prevent any potential apphash mismatches or other oddities that can arise from mixed go runtimes)
Will be done manually during one of the next upgrades as this is a breaking change. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1.
Release notes
Sourced from github.com/cometbft/cometbft-db's releases.
Changelog
Sourced from github.com/cometbft/cometbft-db's changelog.
... (truncated)
Commits
420c96b
build: v1.0.1 (#205)6c14293
revert(goleveldb): removegoleveldb
flag (#204)9b8cce9
build: v1.0.0 (#203)b31daa3
feat!: addgoleveldb
and removepebbledb
build flag (#202)0c657ee
ci: various improvements (#196)cf9a524
v0.15.0 (#195)eb2e732
build(deps): Bump minimum Go version to v1.23 (#194)bf6feef
build(deps): bump github.com/dgraph-io/badger/v4 from 4.2.0 to 4.3.0 (#193)f69e43c
build(deps): bump github.com/google/btree from 1.1.2 to 1.1.3 (#190)58ab00a
build(deps): bump go.etcd.io/bbolt from 1.3.10 to 1.3.11 (#188)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)