Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1 #3364

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2024

Bumps github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1.

Release notes

Sourced from github.com/cometbft/cometbft-db's releases.

v1.0.1

CHANGELOG

v1.0.0

CHANGELOG

v0.15.0

CHANGELOG

v0.14.0

📖 CHANGELOG

v0.13.0

📖 CHANGELOG

Changelog

Sourced from github.com/cometbft/cometbft-db's changelog.

v1.0.1

September 23, 2024

This release reverts the addition of the goleveldb flag, which was deemed as too disruptive to users.

v1.0.0

September 20, 2024

This release swaps the "default" DB from goleveldb to pebbledb. There's now a goleveldb build flag that must be used when using goleveldb. If you're using pebbledb, you don't need a build flag anymore.

BREAKING

  • Add goleveldb build flag. (#202)

v0.15.0

September 9, 2024

This release bumps the Go version to 1.23.

BREAKING CHANGES

  • [go/runtime] Bump minimum Go version to v1.23 (#4039)

v0.14.0

Aug 9, 2024

This release reinstates boltdb and cleveldb as deprecated backend types. Please note that we discourage the use of them, as we plan to discontinue support in a future release.

DEPENDENCIES

  • reinstate BoltDB and ClevelDB as backend DBs (#177)

v0.13.0

Aug 2, 2024

This release:

  • changes the contract of the Iterator Key() and Value() APIs. Namely, the caller is now responsible for creating a copy of their returned value if they want to modify it.
  • removes support for boltDB and clevelDB, which were marked as deprecated in release v0.12.0.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/cometbft/cometbft-db](https://github.com/cometbft/cometbft-db) from 0.12.0 to 1.0.1.
- [Release notes](https://github.com/cometbft/cometbft-db/releases)
- [Changelog](https://github.com/cometbft/cometbft-db/blob/main/CHANGELOG.md)
- [Commits](cometbft/cometbft-db@v0.12.0...v1.0.1)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft-db
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from zmanian as a code owner September 30, 2024 09:58
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 30, 2024
@dependabot dependabot bot requested review from jackzampolin and a team as code owners September 30, 2024 09:58
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter seems to get stuck (also locally). Also, the e2e tests are failing. The e2e error seems to be related to the go version:

#23 [gaiad-builder 10/13] RUN go mod download
#23 0.125 go: go.mod requires go >= 1.23.1 (running go 1.22.8; GOTOOLCHAIN=local)
#23 ERROR: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1

@@ -1,6 +1,8 @@
module github.com/cosmos/gaia/v21

go 1.22.6
go 1.23.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pebbledb requires go 1.23 or higher

IMO the correct way to handle this is to bring this in at the next routine upgrade.

That will ensure that all of the validators compile with go 1.23 (and prevent any potential apphash mismatches or other oddities that can arise from mixed go runtimes)

@MSalopek
Copy link
Contributor

Will be done manually during one of the next upgrades as this is a breaking change.

@MSalopek MSalopek closed this Oct 18, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cometbft/cometbft-db-1.0.1 branch October 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants