fix: multiple temp directories on command executions (#3349)

* remove temp dir when it's not needed anymore

* added changelog

.changelog/unreleased/bug-fixes/3349-multiple-temp-dirs.md

@@ -0,0 +1,2 @@
+- Fix creation of multiple temp directories
+  ([\#3349](https://github.com/cosmos/gaia/pull/3349))

cmd/gaiad/cmd/root.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"errors"
+	"fmt"
 	"io"
 	"os"
 	"path/filepath"
@@ -80,6 +81,9 @@ func NewRootCmd() *cobra.Command {
 		if err := tempApplication.Close(); err != nil {
 			panic(err)
 		}
+		if tempDir != gaia.DefaultNodeHome {
+			os.RemoveAll(tempDir)
+		}
 	}()
 
 	initClientCtx := client.Context{}.
@@ -437,7 +441,7 @@ func (a appCreator) appExport(
 var tempDir = func() string {
 	dir, err := os.MkdirTemp("", ".gaia")
 	if err != nil {
-		dir = gaia.DefaultNodeHome
+		panic(fmt.Sprintf("failed creating temp directory: %s", err.Error()))
 	}
 	defer os.RemoveAll(dir)