-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(systemtest): Fix prune
& gov
test (backport #22190)
#22196
test(systemtest): Fix prune
& gov
test (backport #22190)
#22196
Conversation
@hieuvubk looks like snapshot is still failing here |
we should bump |
Still failing, I will look into it |
tests/systemtests/upgrade_test.go
Outdated
@@ -17,6 +17,9 @@ import ( | |||
) | |||
|
|||
func TestChainUpgrade(t *testing.T) { | |||
// err> panic: failed to load latest version: failed to load store: initial version set to 22, but found earlier version 1 [cosmossdk.io/[email protected]/rootmulti/store.go:256] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't have been brought here. it should be working from the release branch
Seems like |
Okay, as it is unrelated to this, let's merge and fix this one in a follow up |
Description
Closes: #XXXX
Update flag
keep-recent
=>store.keep-recent
for appv2. Will fix main & v0.52Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!
in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Bug Fixes
Tests
This is an automatic backport of pull request #22190 done by [Mergify](https://mergify.com).