Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(systemtest): Fix prune & gov test (backport #22190) #22196

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2024

Description

Closes: #XXXX

Update flag keep-recent => store.keep-recent for appv2. Will fix main & v0.52

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Bug Fixes

    • Updated the command used for the pruning operation to ensure it correctly reflects the new argument format, enhancing the reliability of the pruning feature.
  • Tests

    • Added a new test case for querying deposits after a proposal submission to verify behavior before and after the voting period.
    • Introduced a new function to set the expedited voting period in the genesis state, improving governance proposal testing.
    • Simplified the genesis configuration by removing unnecessary voting period settings, streamlining the test environment setup.

This is an automatic backport of pull request #22190 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 9, 2024 15:50
@julienrbrt
Copy link
Member

@hieuvubk looks like snapshot is still failing here

@hieuvubk
Copy link
Contributor

hieuvubk commented Oct 9, 2024

@hieuvubk looks like snapshot is still failing here

we should bump cosmossdk.io/store, v1.1.1 not contains the fix yet.

@julienrbrt julienrbrt enabled auto-merge (squash) October 9, 2024 16:29
@hieuvubk hieuvubk disabled auto-merge October 9, 2024 17:00
@hieuvubk
Copy link
Contributor

hieuvubk commented Oct 9, 2024

Still failing, I will look into it

@@ -17,6 +17,9 @@ import (
)

func TestChainUpgrade(t *testing.T) {
// err> panic: failed to load latest version: failed to load store: initial version set to 22, but found earlier version 1 [cosmossdk.io/[email protected]/rootmulti/store.go:256]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't have been brought here. it should be working from the release branch

@hieuvubk
Copy link
Contributor

Seems like docker cp v0.50 to the local binary makes it invalid exec format.

@julienrbrt
Copy link
Member

Seems like docker cp v0.50 to the local binary makes it invalid exec format.

Okay, as it is unrelated to this, let's merge and fix this one in a follow up

@julienrbrt julienrbrt merged commit 57a32dd into release/v0.52.x Oct 11, 2024
89 of 92 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22190 branch October 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment