test: e2e/client to system tests (backport #21981)

[mergify]

Description

Closes:
#21923

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:

• confirmed ! in the type prefix if API or client breaking change

• targeted the correct branch (see PR Targeting)

• provided a link to the relevant issue or specification

• reviewed "Files changed" and left comments if necessary

• included the necessary unit and integration tests

• added a changelog entry to CHANGELOG.md

• updated the relevant documentation or specification, including comments for documenting Go code

• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced a comprehensive suite of system tests for gRPC and CometBFT client functionalities, validating key operations such as querying node information, syncing status, and retrieving block details.
  • Added a new method in the RPC client to invoke RPC methods with enhanced error handling and context management.

• Bug Fixes

  • Improved error handling for nil requests and validation of block heights in RPC methods.

• Chores

  • Updated dependencies in the module configuration to include a new dependency and adjust the status of an existing one.

---

This is an automatic backport of pull request #21981 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 91b47cb has failed:

On branch mergify/bp/release/v0.52.x/pr-21981
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 91b47cb5e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    tests/e2e/client/grpc/cmtservice/service_test.go
	new file:   tests/systemtests/cometbft_client_test.go
	modified:   tests/systemtests/rpc_client.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/systemtests/go.mod
	both modified:   tests/systemtests/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

Looks like those tests are failing on 0.52: https://github.com/cosmos/cosmos-sdk/actions/runs/11120593281/job/30897904115?pr=21986

Could you check @JulianToledano?

[JulianToledano]

Could you check @JulianToledano?

Looks like all queries are failing with:
code:1 log:"unknown query path: unknown request" codespace:"cometbft-sdk"

looking into it

[julienrbrt]

Any news on this @JulianToledano ?

[tac0turtle]

is this still blocked?

[JulianToledano]

Any news on this @JulianToledano ?

is this still blocked?

I think so. The problem I think is we haven't registered TendermintService in v2. For example any, q consensus comet fails with:
error in json rpc client, with http response metadata: (Status: 200 OK, Protocol HTTP/1.1). RPC error -32603 - Internal error: no query handler found for /cosmos.base.tendermint.v1beta1.Service/GetLatestBlock

I think that's the reason for tests to fail

[julienrbrt]

V2 failure is indeed expected (as well on main), the issue here is v1 failure.

[JulianToledano]

V2 failure is indeed expected (as well on main), the issue here is v1 failure.

my bad, I was really thinking it was v2 stuff 🤦‍♂️🤦‍♂️🤦‍♂️

However this is pretty weird. I think it has to do with some chars escaping. For this two curl request the results are pretty different:
curl 'http://localhost:1317/cosmos/base/tendermint/v1beta1/validatorsets/latest?pagination.offset=0&pagination.limit=2' | jq

{
  "block_height": "370",
  "validators": [
    {
      "address": "cosmosvalcons17ehdwznex3hjdtzmcqadkuv0p0ex2dtawv255d",
      "pub_key": {
        "@type": "/cosmos.crypto.ed25519.PubKey",
        "key": "R3F2OfB725ziVC3GZeyl5m7UUNDEGn79rmNIImOqpqs="
      },
      "voting_power": "1",
      "proposer_priority": "0"
    }
  ],
  "pagination": {
    "next_key": null,
    "total": "1"
  }
}

but if ? is escaped...
curl 'http://localhost:1317/cosmos/base/tendermint/v1beta1/validatorsets/latest%3Fpagination.offset=0&pagination.limit=2' | jq

{
  "code": 3,
  "message": "type mismatch, parameter: height, error: strconv.ParseInt: parsing \"latest?pagination.offset=0&pagination.limit=2\": invalid syntax",
  "details": []
}

Currently tests are escaping the ? char I think

[JulianToledano]

ok client tests are ok now I think. However fraud tests are failing? any hint to solve this?

[julienrbrt]

ok client tests are ok now I think. However fraud tests are failing? any hint to solve this?

Was it introduced by this PR? If so we need to fix it. Otherwise we can force merge this and fix it later if it is already broken.

[JulianToledano]

ok client tests are ok now I think. However fraud tests are failing? any hint to solve this?

Was it introduced by this PR? If so we need to fix it. Otherwise we can force merge this and fix it later if it is already broken.

The tests are super flacky. After a couple of runs have failed in different tests cases (fraud, authz). Sometimes because of timeouts other times because of connection refused 🤷‍♂️

I've tested locally and all comet_client tests are ok now. This PR only added comet client tests so it should not have modified any other tests.