Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slashing): autocli query config #16659

Merged
merged 14 commits into from
Jul 15, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
Copy link
Member

I'll be pushing this PR to the finish line!

@julienrbrt julienrbrt self-assigned this Jul 10, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 10, 2023
Service: slashingv1beta.Query_ServiceDesc.ServiceName,
RpcCommandOptions: []*autocliv1.RpcCommandOptions{
{
RpcMethod: "Params",
Copy link
Member

@julienrbrt julienrbrt Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The params are wrongly decoded:

params:
  downtime_jail_duration: 600s
  min_signed_per_window: NTAwMDAwMDAwMDAwMDAwMDAw
  signed_blocks_window: "100"
  slash_fraction_double_sign: NTAwMDAwMDAwMDAwMDAwMDA=
  slash_fraction_downtime: MTAwMDAwMDAwMDAwMDAwMDA=

x/slashing/autocli.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

julienrbrt commented Jul 11, 2023

Blocked by #16927 and #16985

@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Jul 14, 2023
@julienrbrt
Copy link
Member

#16985 is valid as well for q mint inflation and other commands, and not only for slashing, so I am going to merge this. Once #16985 is implemented the params command will display better as well.

@julienrbrt julienrbrt marked this pull request as ready for review July 14, 2023 22:36
@julienrbrt julienrbrt requested a review from a team as a code owner July 14, 2023 22:36
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 15, 2023
Merged via the queue into main with commit f7a4add Jul 15, 2023
50 checks passed
@julienrbrt julienrbrt deleted the JeancarloBarrios/slaching-autocli-query-config branch July 15, 2023 06:49
mergify bot pushed a commit that referenced this pull request Jul 15, 2023
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit f7a4add)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/slashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants