Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add insertParagraph buttons #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

✨ Add insertParagraph buttons #67

wants to merge 3 commits into from

Commits on Oct 16, 2018

  1. ✨ Add insertParagraph buttons for html_block

    Exemplary implementation of the insertParagraph buttons.
    
    The buttons need access to the current view to execute the command. Due
    to javascript scoping rules we have to provide a function to get the view when
    we need it instead of a reference to the view itself.
    
    Also, strange things are happening if we create the buttons right in the
    element where we need them. Thus creating them in a local variable and
    adding them when needed.
    
    ToDo:
    * decide where we actually want to use them
    * styling
    micgro42 committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    4fa55d1 View commit details
    Browse the repository at this point in the history
  2. 🚨 Fix travis eslint warnings

    Why didn't they show up during `yarn watch` ? o.O
    micgro42 committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    8944902 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. 🏗 Use class based approach InsertParagraph buttons

    The previous implementation was flawed beyond repair, because there was
    only ever a single instance of the buttons. They were in effect only
    attached to the very last element of those which were supposed to have
    them.
    
    This new implementation lets ProseMirror create the buttons and executes
    the event based on their class and get's the view from the global
    ProseMirror field.
    micgro42 committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    1969ca3 View commit details
    Browse the repository at this point in the history