Insert relative media references if possible #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I guess this works, but I am a bit surprised that you implemented it in PHP. Couldn't you continue to return an absolute ID in the AJAX call and pass it to |
|
I could use the Javascript function as soon as it is merged into core and available in the next release, or leave this PR hanging here until the next release. Which way do you prefer? |
|
I think I would prefer a simple check for the existence of the LinkWizard class. When available use the method, if not use the absolute ID. |
|
I have removed the PHP implementation and we just call the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.