fix: skip update only if the conflict error is related to main output #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
support-checking-resource-type-error
branch
from
664c4cf
to
d0a84cb
Compare
smira
approved these changes
Sep 12, 2024
| @@ -253,7 +253,10 @@ func (ctrl *QController[Input, Output]) reconcileRunning(ctx context.Context, lo | |||
|
|
|||
| return transformError | |||
| }); err != nil { | |||
| if state.IsConflictError(err) { | |||
| if state.IsConflictError(err, | |||
There was a problem hiding this comment.
I think there is same in non-q transform/transform.go which can be updated as well
Yeah, I'm going to do it, |
Fix `qtransform` controller bug which was skipping the reconciliation if the conflict error is returned from the `transformFunc` and is related to the extra outputs. Introduce a way to check if the error was raised by any particular resource type. Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
support-checking-resource-type-error
branch
from
d0a84cb
to
c0a68e9
Compare
|
/m |
Unix4ever
added a commit
to Unix4ever/omni
that referenced
this pull request
Sep 12, 2024
See: cosi-project/runtime#492 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
added a commit
to Unix4ever/omni
that referenced
this pull request
Sep 12, 2024
See: cosi-project/runtime#492 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
added a commit
to siderolabs/omni
that referenced
this pull request
Sep 17, 2024
See: cosi-project/runtime#492 Signed-off-by: Artem Chernyshev <[email protected]> (cherry picked from commit 4c329db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
qtransformcontroller bug which was skipping the reconciliation if the conflict error is returned from thetransformFuncand is related to the extra outputs.Introduce a way to check if the error was raised by any particular resource type.