chore: provide fmt.Stringer for EventType #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple fix to allow easier printing of events. Signed-off-by: Andrey Smirnov <[email protected]>
|
/approve |
andrewrynhard
approved these changes
Mar 2, 2021
AlekSi
reviewed
Mar 3, 2021
| @@ -24,6 +24,10 @@ const ( | |||
| Destroyed | |||
| ) | |||
|
|
|||
| func (eventType EventType) String() string { | |||
| return [...]string{"Created", "Updated", "Destroyed"}[eventType] | |||
There was a problem hiding this comment.
Why not use stringer tool? https://pkg.go.dev/golang.org/x/tools/cmd/stringer
There was a problem hiding this comment.
never used, that, good point, if this requires changing build steps, might be too much work for this PR, but certainly something for the future
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to allow easier printing of events.
Signed-off-by: Andrey Smirnov [email protected]