Add API to set Crypto Provider #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
reviewed
May 31, 2023
Comment on lines
1248
to
1249
| if (cnSign.ContainsKey("countersign0")) { | ||
| AddCounterSignature0(hSignObj, cnSigners.get("countersign0")); | ||
| AddCounterSignature0(hSignObj, cnSign.get("countersign0")); |
There was a problem hiding this comment.
I'm definitely not sure, but it looks to me like this should be the other way around: that the if condition should change to cnSigners instead, because there's already an if statement like this for cnSign on line 1217 above.
There was a problem hiding this comment.
Yeah, probably, but it doesn't change anything in the tests.
There was a problem hiding this comment.
Looks like this was changed in 425c5df in the end?
There was a problem hiding this comment.
I did change it, because it seems logical to me.
emlun
reviewed
Oct 13, 2023
src/main/java/COSE/OneKey.java
Outdated
| @@ -483,22 +496,37 @@ static public OneKey generateKey(AlgorithmID algorithm) throws CoseException { | |||
| * @throws CoseException | |||
| */ | |||
| static public OneKey generateKey(AlgorithmID algorithm, String parameters) throws CoseException { | |||
| return generateKey(algorithm, null, null); | |||
There was a problem hiding this comment.
Looks like this should be generateKey(algorithm, parameters, null)?
emlun
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API to explicitely set a Java Crypto Provider to use for all crypto operations in the library.