Report correct unencrypted length #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COSE_Encrypt_GetContent() returns a valid pointer to the content, but the length parameter is set to 0. The reason for this is because cbOut is set to the correct value, but is then used as the remaining bytes in the EVP functions and gets set to 0. This commit sets the output parameter to the correct value, so we can use the payload safely.
nevelis
force-pushed
the
fix-decrypt-length
branch
from
bf02633
to
08b55fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSE_Encrypt_GetContent() returns a valid pointer to the content, but the length parameter is set to 0.
The reason for this is because cbOut is set to the correct value, but is then used as the remaining bytes in the EVP functions and gets set to 0.
This PR sets the output parameter to the correct value, so we can use the payload safely.