Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Potential enhancement to multiplicative updating #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ejolly
Copy link
Contributor

@ejolly ejolly commented Jul 30, 2021

This tries to use the approach in Blondel et al and Zhu, 16 for using a weight/mask matrix to ignore missing values while doing the Lee & Seung multiplicative update. The latter implementation can be found in a git repo here

It initially seemed to work well for some data where out-of-sample performance increased, but for other data it performed horrendously where predictions weren't even on the same scale as the user ratings. I got a little excited and merged it into master in #31, but given how finicky it seems to be, I've unmerged it now and I'm leaving it in this branch/PR for posterity.

@ejolly ejolly changed the title Enhancement to multiplicative updating [WIP] Potential enhancement to multiplicative updating Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant