Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/contributions #317

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Feature/contributions #317

merged 4 commits into from
Mar 26, 2024

Conversation

mwadams
Copy link
Contributor

@mwadams mwadams commented Mar 18, 2024

Added a contributors document.
Updated the docs to reflect the current 2.0 API
Added an explicit cast and ToString() implementation to JsonPropertyName to reflect the documentation.

@pranayjoshi
Copy link

Thanks for this PR!

Although I'm going to close it, it is very welcome, as it has spurred me to commit the additional changes required to bring the HOL docs up to date with the V2.0 API.

Your changes are included in #317 (along with a bunch of others).

If you wanted to do something incredibly useful, you could work through the HOL and make sure the examples all work for you!

Yeah I totally understand. And will be testing the HOL. Also just to be on the same page, HOL means docs/GettingStartedWithJsonSchemaCodeGeneration.md right?

@mwadams mwadams merged commit 91f1298 into main Mar 26, 2024
5 checks passed
@mwadams mwadams deleted the feature/contributions branch April 3, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants