Fix required field validator not checking if field can be read by use…

…r, before throwing required field error
cortezaproject · Jul 8, 2024 · 301ae29 · 301ae29
1 parent 2151243
commit 301ae29
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/client/web/compose/src/mixins/record.js b/client/web/compose/src/mixins/record.js
@@ -384,8 +384,9 @@ export default {
             if (r.deletedAt) {
               return
             }
+
             const fields = p.module.fields
-              .filter(({ canUpdateRecordValue }) => canUpdateRecordValue)
+              .filter(({ canReadRecordValue, canUpdateRecordValue }) => canReadRecordValue && canUpdateRecordValue)
               .map(({ name }) => name)
 
             // cover the edge case where all fields are not updatable
@@ -397,6 +398,7 @@ export default {
               }
             }
           })
+
           this.errors.push(...errs.set)
         }
       }

diff --git a/lib/js/src/compose/validators/record.ts b/lib/js/src/compose/validators/record.ts
@@ -23,7 +23,10 @@ function genericFieldValidator (field: ModuleField): ValidatorFn<Record> {
     const { value } = arg0
 
     if (field.isRequired) {
-      if (value === undefined || IsEmpty(value)) {
+      const isNewRecord = this.recordID === NoID
+      const canManageFieldValue = isNewRecord ? true : field.canReadRecordValue && field.canUpdateRecordValue
+
+      if ((value === undefined || IsEmpty(value)) && canManageFieldValue) {
         return emptyErr
       }
     }