Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
GTK implementation is left as a TODO because property values could be either secrets or proper values, so handling was arbitrary.
One thing of note, there is a comment asking whether something should be calling
password()
instead ofsecret()
, this may be me misunderstanding the file structure since I didn't look too closely at it, but my understanding is that the first line of an entry is the password.Fixes #207 for library and Cursive, GTK is left for later.