Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Make kwargs required #180

Merged
merged 1 commit into from
Oct 8, 2024
Merged

REF: Make kwargs required #180

merged 1 commit into from
Oct 8, 2024

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Oct 8, 2024

Related: corteva/rioxarray#806

pylint has a new rule: https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/too-many-positional-arguments.html

This change will enforce the usage of kwargs.

Benefits:

  • code more readable
  • code more robust
  • reduce coding errors when making changes

@snowman2 snowman2 added this to the 0.6.0 milestone Oct 8, 2024
@snowman2 snowman2 merged commit 4307244 into master Oct 8, 2024
12 of 15 checks passed
@snowman2 snowman2 deleted the lnt branch October 8, 2024 13:50
@snowman2 snowman2 modified the milestones: 0.6.0, 0.7.0 Oct 8, 2024
Copy link

@justingruca justingruca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants