V4.0.x Work-in-progress branch #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for cornerstone-wado-image-loader ready! 🔨 Explore the source changes: 86a1a59 🔍 Inspect the deploy log: https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/614196a9cb38240007ab7b8d 😎 Browse the preview: https://deploy-preview-394--cornerstone-wado-image-loader.netlify.app |
…at least until WASM build is ready
…trieving images BREAKING CHANGE: An external dependency must be updated to a higher version.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the WebAssembly builds of each codec (found here: https://github.com/cornerstonejs/codecs) in the WADO Image Loader.
It still needs a ton of testing, but this will be the basis for the next major version of this library.
If you want to test this in OHIF now, you can look at this branch: https://github.com/OHIF/Viewers/commits/feat/v2-main-codectest
You will need to build this library and use yarn link to link the cornerstone-wado-image-loader into OHIF for the branch to work.
Credit is due to @chafey for pioneering the WASM codec work and @dannyrb for starting to bring it into this library.
The biggest remaining issue is consumption of the library. Right now, in order to dynamically load the WASM modules, the consuming libraries need to copy the entire
distfolder from the WADO Image Loader into their outputdistfor their application (e.g via CopyWebpackPlugin). It would be nicer if we could avoid this step and also keep the bundle small.TODO:
Live demo is here:
https://deploy-preview-394--cornerstone-wado-image-loader.netlify.app/wadouri/index.html
1.2.840.10008.1.2.4.51 JPEG Baseline (Processes 2 & 4): Default Transfer Syntax for Lossy JPEG 12-bit Image Compression (Process 4 only)
We need to figure out how to get a WASM build of this working: https://github.com/cornerstonejs/codecs/tree/main/packages/libjpeg-turbo-12bit
Note that it doesn't use TurboJPEG API for 12 bit support, it's the old libjpeg api