[Enhancement] Extension of initializing arbitrary bit integer in hcl.scalar from string #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecmay
reviewed
Jan 7, 2022
tvm/src/codegen/llvm/llvm_module.cc
Outdated
Comment on lines
156
to
176
| void InitHB(Array<LoweredFunc> funcs, std::string target) { | ||
| InitializeLLVM(); | ||
| CHECK(target.length() >= 11 && target.substr(0, 11) == "hammerblade"); | ||
| std::ostringstream config; | ||
| config << "-mtriple=riscv32-unknown-unknown -mabi=ilp32f"; | ||
| tm_ = GetLLVMTargetMachine(config.str()); | ||
| std::unique_ptr<CodeGenLLVM> cg = CodeGenLLVM::Create(tm_); | ||
| ctx_ = std::make_shared<llvm::LLVMContext>(); | ||
| std::unique_ptr<llvm::LLVMContext> ctx(new llvm::LLVMContext()); | ||
| cg->Init(funcs[0]->name, tm_, ctx_.get(), false, false); | ||
| for (LoweredFunc f : funcs) { | ||
| cg->AddFunction(f); | ||
| } | ||
| cg->AddMainFunction(funcs[0]->name); | ||
| module_ = cg->Finish(); | ||
| module_->addModuleFlag(llvm::Module::Warning, "tvm_target", | ||
| llvm::MDString::get(*ctx_, target)); | ||
| target_ = target; | ||
| mptr_ = module_.get(); | ||
| this->SaveToFile("hb_test.ll", "ll"); | ||
| } |
There was a problem hiding this comment.
This is for HB simulation in HCL right? I would suggest using another PR to introduce HB backend in HCL
tvm/src/codegen/llvm/llvm_module.cc
Outdated
Comment on lines
304
to
309
| TVM_REGISTER_API("codegen.build_hammerblade") | ||
| .set_body([](TVMArgs args, TVMRetValue* rv) { | ||
| std::shared_ptr<LLVMModuleNode> n = std::make_shared<LLVMModuleNode>(); | ||
| n->InitHB(args[0], args[1]); | ||
| *rv = runtime::Module(n); | ||
| }); |
There was a problem hiding this comment.
Same here. HB target may as well be introduced separately.
tvm/src/codegen/llvm/codegen_llvm.cc
Outdated
Comment on lines
1587
to
1600
| if (kernel_has_assert_[op->name]) { | ||
| llvm::BasicBlock* assert_true_kernel = | ||
| llvm::BasicBlock::Create(*ctx_, "assert_true_kernel", function_); | ||
| llvm::BasicBlock* assert_false_kernel = | ||
| llvm::BasicBlock::Create(*ctx_, "assert_false_kernel", function_); | ||
| llvm::Value* assert_flag = | ||
| builder_->CreateLoad(llvm::Type::getInt32Ty(*ctx_), assert_global_ptr_); | ||
| llvm::Value* cond = builder_->CreateICmpEQ(assert_flag, ConstInt32(1)); | ||
| builder_->CreateCondBr(cond, assert_true_kernel, assert_false_kernel); | ||
| builder_->SetInsertPoint(assert_false_kernel); | ||
| AssertFreeVars(); | ||
| builder_->CreateRet(ConstInt32(1)); | ||
| builder_->SetInsertPoint(assert_true_kernel); | ||
| } |
There was a problem hiding this comment.
Why inserting the kernel only when there is an assertion inside? can you please explain?
There was a problem hiding this comment.
I did not modify this part, it is the same with what inside the master branch.
There was a problem hiding this comment.
@zzy82518996 can you run "git pull upstream master" to merge the latest changes in main branch? It seems that some changes are missing and the local CI/CD is not working as expected.
added 2 commits
January 13, 2022 15:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fixing issues
Add feature: enable initializing the arbitrary bit integer using hcl.scalar from string
Link to the tests: tests/test_scalar.py
Detailed Description : We extend the heteroCL IR by adding the CastStr expression, and use APInt class to convert string to ConstantInt class in codegen_llvm.