Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed styling of add_price_and_bedroom_attributes.ts and removed unused imports #362

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

kea-roy
Copy link
Member

@kea-roy kea-roy commented Apr 16, 2024

Summary

This pull request is a continuation of closed pull request #346 to resolve minor formatting issues in the add_price_and_bedroom_attributes.ts script.

Test Plan

No tests are needed because there are only comment and import changes. Compiles successfully.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 7.

@kea-roy kea-roy changed the title Fixed styling from feedback and removed unused imports Fixed styling of add_price_and_bedroom_attributes.ts and removed unused imports Apr 16, 2024
Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you used my previous comment about using the docstring and improved it, good job! You also changed your previous placeholder comment, making the codebase neater and easier to understand.

@ggsawatyanon ggsawatyanon merged commit 025f2d2 into main Apr 22, 2024
5 checks passed
@ggsawatyanon ggsawatyanon deleted the add-price-bedroom-attr branch April 22, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants