Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Landlord Redirect Button (Change to Button Style) #350

Closed
wants to merge 6 commits into from

Conversation

CasperL1218
Copy link
Contributor

Implement Landlord Redirect Button (Change to Button Style)

  • Change the landlord redirect text on the review from underlined text to a button style
Screenshot 2024-02-21 at 18 12 49 *The [Property: ] text is not underlined now Screenshot 2024-02-21 at 18 12 53 *The text/button area becomes darker when the mouse hovers over it. It has a similar style to the [Visit Landlord] button on ApartmentCard.

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 22, 2024

[diff-counting] Significant lines: 24.

Copy link
Member

@kea-roy kea-roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Works as intended with responsive styling. Tested on various screen sizes and the button looks correct for all sizes.

But I don't think any of the styling is necessary. If you want to simplify the code a bit, you can try removing your custom stylings on lines 195-200. I tried running the code without the styling and it seems to look the same. Perhaps Material UI takes care of the styling for this component?

@CasperL1218
Copy link
Contributor Author

CasperL1218 commented Feb 22, 2024

I tried removing the styling, and it works the same way as intended.

I have removed the styling on lines 195-200. Thanks for pointing that out!

kea-roy
kea-roy previously approved these changes Feb 22, 2024
Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on your first task! Good implementation of the button. Could you match the landlord button styling further by making the text not capitalized? Also ensure that the font size is the same as the review text font size.
Example below:
image

@dan-ieljin dan-ieljin closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants