Updating Apartment Page UI/Functionality V3 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 146. |
|
Visit the preview URL for this PR (updated for commit 7d0eb92): https://cu-apts-staging--pr309-updating-apartment-r-ni160rpr.web.app (expires Mon, 20 Nov 2023 23:51:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 096ac87b789b31770a01964fe0aaa92d563b9353 |
|
This PR looks great and implements a needed feature that provides users with more information about each apartment's reviews! Perhaps you could delete the handleShowMore function instead of commenting it out? Good job! |
thuypham03
requested changes
Nov 13, 2023
thuypham03
approved these changes
Nov 13, 2023
mluo24
pushed a commit
that referenced
this pull request
Nov 15, 2023
* migrating changes * specification * fixed precentage of segment * adjust spacing * fixed bug * fixed bug * fixed sizing * size of landlord info --------- Co-authored-by: Thuy Pham <[email protected]> Co-authored-by: thuypham03 <[email protected]>
AnkitLakkapragada
pushed a commit
that referenced
this pull request
Dec 1, 2023
* migrating changes * specification * fixed precentage of segment * adjust spacing * fixed bug * fixed bug * fixed sizing * size of landlord info --------- Co-authored-by: Thuy Pham <[email protected]> Co-authored-by: thuypham03 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to update the current User Interface of the apartment page. Instead of the linear scale for the feature ratings, there is now 5 subsections for each review scale.
Test Plan
Tested on resizing the browser window.
The Current Look:
Figma:
