Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New landlord info sidebar on apartment page #307

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Conversation

mluo24
Copy link
Contributor

@mluo24 mluo24 commented Oct 14, 2023

Summary

This PR implements new sidebar for the landlord information, including new buttons and review cards. There are some edits to the styled review component.

Link to design

Documentation

Most of this was made with Grids to plan for responsive/mobile design and to get flexbox.

landlordId is the landlord ID, necessary to get the detail link for the landlord - this was added to the AptInfo component.

For the StyledReview, I made it so the size of the icons would change according to the size of the review prop. Otherwise, if you set review to "small" or something, it would not change sizes.

Test Plan

image

image

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 14, 2023

[diff-counting] Significant lines: 123.

@mluo24 mluo24 temporarily deployed to staging October 14, 2023 18:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Visit the preview URL for this PR (updated for commit 5dc3e12):

https://cu-apts-staging--pr307-new-landlord-info-de-pe9287pr.web.app

(expires Sun, 19 Nov 2023 06:20:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

@thuypham03
Copy link
Collaborator

Great job on adapting the new landlord design! Can you help change the following:

  • Add the "Landlord" header to the top of the section
  • Lower the header level of "Information" and "Other properties..." and try to make it to fit on a line as the picture below
Screenshot 2023-11-06 at 4 24 30 PM

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new UI! This helps navigate users to landlord's page easier and allow clickable link that leads to contact page immediately.

@mluo24 mluo24 merged commit 3d95858 into main Nov 13, 2023
7 checks passed
@mluo24 mluo24 deleted the new-landlord-info-design branch November 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants