Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Review Success Message #303

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Changed Review Success Message #303

merged 2 commits into from
Oct 12, 2023

Conversation

ggsawatyanon
Copy link
Contributor

Summary

This pull request changed the review submit confirmation message to inform the user that their review is waiting for approval from the admin.

Test Plan

Review submitted

Notes

Breaking Changes

@ggsawatyanon ggsawatyanon temporarily deployed to staging October 2, 2023 04:31 — with GitHub Actions Inactive
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 2.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Visit the preview URL for this PR (updated for commit 303cac0):

https://cu-apts-staging--pr303-reviewsuccessmessage-bgu6x1dn.web.app

(expires Mon, 16 Oct 2023 01:49:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change helps the user know what to expect after submit reviews. Before, they don't know where the reviews have gone!

@thuypham03 thuypham03 temporarily deployed to staging October 9, 2023 01:47 — with GitHub Actions Inactive
@jesshan700
Copy link
Contributor

Already merged but looks good! The changes solves the confusion that the user might have regarding why their review doesn't show up immediately.

@thuypham03 thuypham03 merged commit af80a95 into main Oct 12, 2023
7 checks passed
@thuypham03 thuypham03 deleted the reviewSuccessMessage branch October 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants