Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Apartment Page UI/Functionality #298

Closed
wants to merge 5 commits into from

Conversation

cyrus14
Copy link
Contributor

@cyrus14 cyrus14 commented Sep 25, 2023

Summary

This PR is to update the current User Interface of the apartment page. Instead of the linear scale for the feature ratings, there is now 5 subsections for each review scale.

Test Plan

Tested on resizing the browser window.
The Current Look:
image

Figma:
image

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cyrus14
❌ Cyrus Irani


Cyrus Irani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Member

dti-github-bot commented Sep 25, 2023

[diff-counting] Significant lines: 124.

@cyrus14 cyrus14 changed the title [WIP] Updating Apartment Page UI/Functionality Updating Apartment Page UI/Functionality Oct 2, 2023
@cyrus14 cyrus14 temporarily deployed to staging October 20, 2023 19:30 — with GitHub Actions Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 56cdaf1):

https://cu-apts-staging--pr298-moveavgratingslandlo-su4k95d3.web.app

(expires Fri, 27 Oct 2023 19:33:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

@cyrus14 cyrus14 closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants