Camera Feature (WIP) #170
Draft
Camera Feature (WIP) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neketka
requested changes
Mar 25, 2024
| }); | ||
| } | ||
|
|
||
| toggleCamera() async { |
There was a problem hiding this comment.
Add a return type here Future<...> otherwise this returns dynamic
| fontWeight: FontWeight.w700, | ||
| ), | ||
| ), | ||
| imagePath == "" |
There was a problem hiding this comment.
It looks like you can use a better state here instead of imagePath == "". It's confusing to see why an empty image path means we have a camera preview. If you plan to keep this, please add a comment explaining why you make this comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing the camera and photo taking feature after a user has completed a challenge.
Remaining TODOs:
Test Plan
Notes
Blockers
Breaking Changes