-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pgAdmin rule exclusions plugin #9
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Florian Michel <[email protected]>
Hi @flo-mic, this looks very nice! We will review your work and discuss integration soon. |
Very nice. Thank you very much @flo-mic. You are the the first 3rd party contributor with a plugin and I'd be very happy to have you in the registry. This is all a bit dynamic and the moment and unfortunately this forces you to run after a moving target. Yet, I believe things have stabilized quite much and you should be able to meet our new standard easily.
|
Signed-off-by: Florian Michel <[email protected]>
@dune73 What exactly do you mean with contact address? In the readme of the plugin? Have not seen such contact address in any other plugin. But for now I have also added the CONTRIBUTOR.md file as it is done on all other plugins. Beside of the contact address I have done all suggested changes and also updated the readme of this PR. Let me know if something is missing. |
Thanks, it looks very good! I suggest more changes:
Besides this and the fact that i wasn't able to test it (as i'm not using PostreSQL), i think this is a very good 3rd party plugin and i suggest to include it in the list. |
@flo-mic : Regarding Contact address: With the official plugins, the contact address is the CRS project. Yet with 3rd party plugins, we would like to have a contact address for inclusion. The case could be different if your plugin would become an official plugin. This would probably need some time though, so we still need a contact address. |
@flo-mic Looks like we have some conflicts now :( Can you solve them and update this PR? |
@flo-mic ping. |
This PR adds a 3rd party pgAdmin rule exclusion plugin to the registry. I developed this for myself but if you have interests in hosting this under the repos of coreruleset and making it an "official" plugin let me know.