Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: zincati release 0.0.27 #1119

Merged
merged 2 commits into from
Nov 8, 2023
Merged

cargo: zincati release 0.0.27 #1119

merged 2 commits into from
Nov 8, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 8, 2023

Changes:

  • cargo: update all dependencies to latest versions
  • cargo: bump libsystemd to 0.7.0 to fix fd leak

@jmarrero jmarrero enabled auto-merge November 8, 2023 16:10
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jlebon
Copy link
Member Author

jlebon commented Nov 8, 2023

Hmm, CI failing with:

[2023-11-08T16:58:16.877Z] Nov 08 16:58:11 qemu0 kola-runext-test-experimental.sh[2109]: + sudo -u core busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefresh
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 sudo[2111]:     root : PWD=/tmp/tmp.hQT8Mp1WJk ; USER=core ; COMMAND=/usr/bin/busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefresh
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + assert_file_has_content err.txt 'Access denied'
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + fpath=err.txt
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + shift
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + for re in "$@"
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + grep -q -e 'Access denied' err.txt
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + _fatal_print_file err.txt 'File '\''err.txt'\'' doesn'\''t match regexp '\''Access denied'\'''
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + file=err.txt
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + shift
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + ls -al err.txt
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2114]: -rw-r--r--. 1 root root 41 Nov  8 16:58 err.txt
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + sed -e 's/^/# /'
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2115]: # Call failed: The name is not activatable
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + fatal 'File '\''err.txt'\'' doesn'\''t match regexp '\''Access denied'\'''
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + echo error: File ''\''err.txt'\''' 'doesn'\''t' match regexp ''\''Access' 'denied'\'''
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: error: File 'err.txt' doesn't match regexp 'Access denied'
[2023-11-08T16:58:16.877Z] Nov 08 16:58:12 qemu0 kola-runext-test-experimental.sh[2109]: + exit 1

Not sure what's going on here. Will have to dig.

@jlebon
Copy link
Member Author

jlebon commented Nov 8, 2023

OK right, this seems related to the zbus bump (see e.g. #966 (comment)).

The weird thing is that if I test it manually, I do still get the same "Access denied" error message, so I think there might be something more subtle going on there. I thought maybe we were racing with Zincati actually coming up on the bus, but adding hacks for that doesn't fix the test either.

Anyway, decided not to try to solve that right now and just backed out the zbus-related bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants