Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysusers.d/50-zincati.conf: tweak comments #1101

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 6, 2023

The sysusers docs say that lines starting with # are ignored, but I think there's RPM macros or something that trip up on this:

error: lua script failed: [string "add_sysuser"]:16: invalid sysuser type: #Zincati
  3<        (%lua)
  2<      (%add_sysuser)
error: lua script failed: [string "add_sysuser"]:16: invalid sysuser type: #Type
  3<        (%lua)
  2<      (%add_sysuser)

And systemd's sysusers dropins all also seem to have a space separator.

Let's add a space to see if it helps.

The sysusers docs say that lines starting with `#` are ignored, but I
think there's RPM macros or something that trip up on this:

    error: lua script failed: [string "add_sysuser"]:16: invalid sysuser type: #Zincati
      3<        (%lua)
      2<      (%add_sysuser)
    error: lua script failed: [string "add_sysuser"]:16: invalid sysuser type: #Type
      3<        (%lua)
      2<      (%add_sysuser)

And systemd's sysusers dropins all also seem to have a space separator.

Let's add a space to see if it helps.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon enabled auto-merge October 6, 2023 21:14
@jlebon jlebon merged commit 10fc39c into coreos:main Oct 6, 2023
7 checks passed
@travier
Copy link
Member

travier commented Oct 7, 2023

I'd say we could even completely remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants