Skip to content

Commit

Permalink
util: Remove an (effectively) unused GCancellable
Browse files Browse the repository at this point in the history
This will be fully obsoleted with #2206
  • Loading branch information
cgwalters authored and openshift-merge-robot committed Aug 26, 2020
1 parent e041815 commit 6232144
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/app/rpmostree-db-builtin-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ _builtin_db_list (OstreeRepo *repo,
if (!*mrev)
mrev = NULL;

range_revs = _rpmostree_util_get_commit_hashes (repo, revdup, mrev, cancellable, error);
range_revs = _rpmostree_util_get_commit_hashes (repo, revdup, mrev, error);
if (!range_revs)
return FALSE;

Expand Down
2 changes: 1 addition & 1 deletion src/app/rpmostree-db-builtin-version.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ _builtin_db_version (OstreeRepo *repo, GPtrArray *revs,
if (!*mrev)
mrev = NULL;

range_revs = _rpmostree_util_get_commit_hashes (repo, revdup, mrev, cancellable, error);
range_revs = _rpmostree_util_get_commit_hashes (repo, revdup, mrev, error);
if (!range_revs)
return FALSE;

Expand Down
5 changes: 2 additions & 3 deletions src/libpriv/rpmostree-util.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ GPtrArray *
_rpmostree_util_get_commit_hashes (OstreeRepo *repo,
const char *beg,
const char *end,
GCancellable *cancellable,
GError **error)
{
GPtrArray *ret = NULL;
Expand All @@ -121,14 +120,14 @@ _rpmostree_util_get_commit_hashes (OstreeRepo *repo,
char *checksum = NULL;
gboolean worked = FALSE;

if (!ostree_repo_read_commit (repo, beg, NULL, &beg_checksum, cancellable, error))
if (!ostree_repo_read_commit (repo, beg, NULL, &beg_checksum, NULL, error))
goto out;

ret = g_ptr_array_new_with_free_func (g_free);
g_ptr_array_add (ret, g_strdup (beg)); /* Add the user defined REFSPEC. */

if (end &&
!ostree_repo_read_commit (repo, end, NULL, &end_checksum, cancellable, error))
!ostree_repo_read_commit (repo, end, NULL, &end_checksum, NULL, error))
goto out;

if (end && g_str_equal (end_checksum, beg_checksum))
Expand Down
1 change: 0 additions & 1 deletion src/libpriv/rpmostree-util.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ GPtrArray *
_rpmostree_util_get_commit_hashes (OstreeRepo *repo,
const char *beg,
const char *end,
GCancellable *cancellable,
GError **error);

gboolean
Expand Down

0 comments on commit 6232144

Please sign in to comment.