providers/applehv: Add Apple Hypervisor #1696
Conversation
baude
force-pushed
the
applehv2
branch
4 times, most recently
from
df97d9f
to
4caa593
Compare
|
updated based on comments. |
|
Agree with the two remaining comments: Let's document what the URL and port mean and how to setup QEMU to test it maybe? |
do you really mean qemu? |
|
Yes. We don't need the full QEMU setup, only what additional options would be needed to add to an existing QEMU instance to be able to test this. I think QEMU has support for vsock which should let us test this code outside of |
|
We don't have specific doc pages for each provider yet. So either some comments here or a new doc page would be good. |
|
ok, i have updated this pr based on comments. i will add specific documentation on how to do this without podman/vfkit/gvproxy to the fcos documentation like i did with hyperv. |
| need an httpd server that is capable of responding to a GET over vsock. Alternatively, the httpd | ||
| server could listen on a unix domain socket (uds) and a utility would need to be written that copies | ||
| from the vsock <-> uds | ||
| */ |
There was a problem hiding this comment.
Would this be a valid "diagram" of the platform setup?
Emulated: HTTP server (podman) <--> vsock (host) <--> QEMU <--> kernel (vsock-virtio) <--> Ignition (vsock client)
Actual: HTTP server (podman) <--> vsock (host) <--> Apple HV <--> kernel (vsock-virtio) <--> Ignition (vsock client)
|
A couple more questions to clarify the limit between what's set by the platform and what we're deciding. |
|
OK, LGTM. Thanks for the clarifications. |
|
@prestist I'll let you merge. We'll likely need to do a release soon to get that in FCOS. |
baude
force-pushed
the
applehv2
branch
2 times, most recently
from
99dc001
to
5858f58
Compare
* Add applehv platform * Ignintion read from vsock connection with the host See coreos/fedora-coreos-tracker#1533 and coreos/fedora-coreos-tracker#1548 Signed-off-by: Brent Baude <[email protected]>
A review comment to coreos#1696 suggested I see if I could eliminate a pair of modules needed in the ramdisk to consume an ignition file over vsock. In doing the testing, I experienced a false positive; unfortunately, I have determined they are in fact needed and this PR asks to add them again. Signed-off-by: Brent Baude <[email protected]>
See coreos/fedora-coreos-tracker#1533 and
coreos/fedora-coreos-tracker#1548