Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/promote-config: clone fedora-coreos-config with submodules #999

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 16, 2024

To promote submodule content, we need to also make sure we clone the repo with git submodules in the first place.

To promote submodule content, we need to also make sure we clone the
repo with git submodules in the first place.
Copy link

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 213e845 into coreos:main Dec 16, 2024
1 check passed
@dustymabe
Copy link
Member

looks like the code still specifies no recurse submodules for some reason:

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/next*:refs/remotes/origin/next* +refs/tags/next*:refs/tags/next*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants