-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs: Add a bump-jenkins-plugins job #917
Conversation
eabe11d
to
875cef7
Compare
60b522b
to
73ce554
Compare
We can create a PR with the jenkins plugin updates with this code - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but this looks sane overall!
056fb03
to
3558fe9
Compare
@jlebon I have addressed all the comments and have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Mostly looking good. A few comments.
f5b72a8
to
d5a9f99
Compare
Posting the links for the PR and jenkins build below for reference: PR for the plugins update - coreosbot-releng#10 |
Haven't reviewed the code again (will leave that to @dustymabe), but just looking at the example PR in coreosbot-releng#10, we should include in the commit message the job information. Compare e.g. to: coreos/fedora-coreos-config@1598859 (see |
Making sure if I understood it right, the commit message already includes the job information as suggested. Please let me know if there are any additional improvements to be made. |
Maybe he got confused because the PR description doesn't have that information. |
We are creating this bump-jenkins-job in order to periodically update the latest plugin version of Jenkins offered by Openshift/Jenkins. bump-jenkins-job automates the process of checking for updates to Jenkins plugins, updating the plugin versions in a configuration file, pushing the changes to a Git repository, and opening a pull request for review. Plugin Update Process: This job reads a list of plugins from the file plugins.txt in the repository. It iterates over each plugin, checks for updates and if a newer version is available, it updates the version in the file. For each plugin, it fetches the latest version by querying a URL based on the Jenkins plugin repository structure. If an update is found, it modifies the plugins.txt file to reflect the new version. The updates in the plugins.txt file are committed and pushed to the pr_branch. It also opens a pull request with the updated plugin versions. Ref: coreos#562 Co-authored-by: Michael Armijo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
I think the remaining piece in my mind is what happens to the PRs when they are created?
Do we just merge them or do we require someone to verify the plugins are able to be deployed and an instance brought up first?
It was decided for now that the reviewer would test in staging by pointing the buildconfig at the PR and then make the merge. |
Yes, that's exactly what happened. :) |
We are creating this
bump-jenkins-job
in order to periodically update the latest plugin version of Jenkins offered by Openshift/Jenkins.bump-jenkins-job
automates the process of checking for updates to Jenkins plugins, updating the plugin versions in a configuration file, pushing the changes to a Git repository, and opening a pull request for review.Plugin Update Process:
plugins.txt
file to reflect the new version.plugins.txt
file are committed and pushed to thepr_branch
.Ref: #562