Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola aws stage enhancements #133

Merged
merged 3 commits into from
Sep 17, 2019
Merged

kola aws stage enhancements #133

merged 3 commits into from
Sep 17, 2019

Conversation

dustymabe
Copy link
Member

  • Jenkinsfile: move kola AWS tests above Archive stage
  • Jenkinsfile: shorten and enhance Kola stage names
  • Jenkinsfile: check KOLA AWS cred before Kola:AWS stage

Since we kick off the tests and they run in parallel
there is no reason we can't kick them off before the
archive stage which takes some time because of compression.

In other words, this way we'll get results sooner.
They are now both shorter and more descriptive!
This makes sure the config file exists before kicking off
the build that will run kola AWS tests.
@dustymabe
Copy link
Member Author

I opened as a draft PR because I haven't had a change to test and I'm worried about the last commit being invalid syntax. If someone wants to confirm that syntax without explicit testing then I'll be happy to merge and watch it in prod.

@dustymabe
Copy link
Member Author

requesting review from @arithx since this is kola related

@dustymabe
Copy link
Member Author

@arithx this PR should address #132 (comment)

@dustymabe dustymabe requested a review from arithx September 12, 2019 19:32
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 3 commits individually look good to me pending they pass testing.

@@ -193,7 +193,7 @@ podTemplate(cloud: 'openshift', label: 'coreos-assembler', yaml: pod, defaultCon
}
}

stage('QEMU Kola Run') {
stage('Kola:QEMU') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but at a later point we should probably split out the Kola:QEMU run into it's own separate job (and potentially make it not blocking in the middle of the run so we can re-run if we happen to run into a flake without having to rebuild the entire image).

@dustymabe
Copy link
Member Author

All 3 commits individually look good to me pending they pass testing.

passed testing on my end. merging

@dustymabe dustymabe marked this pull request as ready for review September 17, 2019 14:16
@dustymabe dustymabe merged commit 42188bf into coreos:master Sep 17, 2019
@dustymabe dustymabe deleted the kolamove branch September 17, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants