-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platforms.adoc: add VirtualBox documentation #377
Conversation
63d9b60
to
036ec77
Compare
5345123
to
92bf5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
92bf5c4
to
9190757
Compare
0bfd176
to
2951188
Compare
Requires coreos/coreos-assembler#2489 to land in a stable release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally. I paired with @prestist on this, though, so shouldn't approve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. Though the most valuable thing to do would be to have someone grab one of these new artifacts and run a test. IIUC @ravanelli has a mac with VBOX set up so maybe she would be willing.
78c4165
to
25b56e4
Compare
25b56e4
to
279a38a
Compare
eac79ac
to
3fa8898
Compare
LGTM! |
Added documentation around virtualbox. Going through steps to add virtualbox to a supported type for our offical release as per coreos/fedora-coreos-tracker#1008