Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: /boot is now mounted ro #237

Merged
merged 1 commit into from
Feb 3, 2021
Merged

storage: /boot is now mounted ro #237

merged 1 commit into from
Feb 3, 2021

Conversation

bgilbert
Copy link
Contributor

Followup to #236 (comment). Hold until coreos/fedora-coreos-config#659 lands in stable.

@lucab lucab added the hold label Jan 18, 2021
travier
travier requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@travier travier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also update the listing for /boot just above those lines? Thanks!. Edit: Done

@travier
Copy link
Member

travier commented Feb 1, 2021 •
edited
Loading

Hold for next stable release (this week).

kelvinfan001
kelvinfan001 approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@kelvinfan001 kelvinfan001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert added hold and removed hold labels Feb 3, 2021
@bgilbert
Copy link
Contributor Author

bgilbert commented Feb 3, 2021

Rebased; awaiting fixed stable release.

@bgilbert bgilbert removed the hold label Feb 3, 2021
@bgilbert bgilbert merged commit 9e7c061 into coreos:master Feb 3, 2021
@bgilbert bgilbert deleted the boot-ro branch February 3, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@kelvinfan001 kelvinfan001 kelvinfan001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgilbert @travier @kelvinfan001 @lucab