Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] tree: promote changes from testing-devel at 262ea8b2b031a81a3cb379a93803ebdc2d407709 #3302

Closed
wants to merge 1 commit into from
Closed

[next] tree: promote changes from testing-devel at 262ea8b2b031a81a3cb379a93803ebdc2d407709 #3302

wants to merge 1 commit into from

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Dec 16, 2024 •
edited
Loading

c4rt0
c4rt0 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

c4rt0
c4rt0 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@c4rt0 c4rt0 enabled auto-merge (rebase) December 16, 2024 11:39
dustymabe
dustymabe approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

hmm. there still isn't something right with the submodule promotion:

git rev-parse HEAD^{commit} # timeout=10
git config core.sparsecheckout # timeout=10
git checkout -f 00ef10a908f2c860aeda869b45dfedd6e58a67d2 # timeout=10
git remote # timeout=10
git submodule init # timeout=10
Could not perform submodule update

@jlebon jlebon disabled auto-merge December 16, 2024 14:57
jlebon added a commit to jlebon/fedora-coreos-streams that referenced this pull request Dec 16, 2024
@jlebon
workflows/promote-config: use Fedora instead of Ubuntu
3faac8b 
Currently, `ubuntu-latest` is still 22.04 which has git v2.34. Let's use
`fedora:latest` instead, which has much newer git.

I suspect this should fix submodule-related issues we're seeing with
promotion:

coreos/fedora-coreos-config#3302 (comment)
@jlebon jlebon mentioned this pull request Dec 16, 2024
Merged
@jlebon
Copy link
Member

jlebon commented Dec 16, 2024

Let's try coreos/fedora-coreos-streams#997.

jlebon added a commit to jlebon/fedora-coreos-streams that referenced this pull request Dec 16, 2024
@jlebon
workflows/promote-config: use Fedora instead of Ubuntu
82d9aff 
Currently, `ubuntu-latest` is still 22.04 which has git v2.34. Let's use
`fedora:latest` instead, which gives us much newer git (v2.47.1).

I suspect this should fix submodule-related issues we're seeing with
promotion:

coreos/fedora-coreos-config#3302 (comment)
dustymabe pushed a commit to coreos/fedora-coreos-streams that referenced this pull request Dec 16, 2024
@jlebon @dustymabe
workflows/promote-config: use Fedora instead of Ubuntu
ac64d24 
Currently, `ubuntu-latest` is still 22.04 which has git v2.34. Let's use
`fedora:latest` instead, which gives us much newer git (v2.47.1).

I suspect this should fix submodule-related issues we're seeing with
promotion:

coreos/fedora-coreos-config#3302 (comment)
@jlebon jlebon closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c4rt0 c4rt0 c4rt0 approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coreosbot-releng @dustymabe @jlebon @c4rt0 @coreosbot