image.yaml: enable sysroot-ro #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
approved these changes
Mar 16, 2020
After #303, we're essentially already using it. This is more so that we don't go back to not use it once we make it opt-in in cosa (coreos/coreos-assembler#1235). I think most issues have been shaken out now. At least updates work, so any other remaining issues we should be able to fix in follow-ups if necessary. |
|
Let's hold this until coreos/coreos-assembler#1235 merges in case the field name changes there. |
We want to use the new read-only `/sysroot` feature of libostree. Opt-in to that to tell cosa we support it and want it. For more details, see: ostreedev/ostree#1265 coreos/coreos-assembler#1235
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
May 18, 2020
See coreos/fedora-coreos-tracker#343 (comment) Basically we need to make raw `ostree` operations work and not just `ostree admin`. Pairs with coreos/fedora-coreos-config#304
|
Force pushed this to update to the new name from coreos/coreos-assembler#1235 |
Per coreos/coreos-assembler#1235 (comment) it sounds like this needs to merge first. |
ashcrow
approved these changes
May 18, 2020
|
LGTM merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the new read-only
/sysrootfeature of libostree. Opt-into that to tell cosa we support it and want it.
For more details, see:
ostreedev/ostree#1265
coreos/coreos-assembler#1235