Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildroot: Add clippy #2568

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

cgwalters
Copy link
Member

For the same reason we have rustfmt; I plan to rework the ostree-rs-ext build flow to use this there.

For the same reason we have `rustfmt`; I plan to rework the
ostree-rs-ext build flow to use this there.
@jmarrero
Copy link
Member

[+] Found files with whitespace at the end of line 👀

@aaradhak
Copy link
Member

Looks like the whitespace failures are handled in this - #2566

@cgwalters
Copy link
Member Author

Two mistakes:

  • Adding a new CI check without fixing the existing problems it finds (and also, trailing whitespace is not some kind of critical blocker)
  • Adding unrelated fixes only into an existing PR instead of splitting them out into something that can be merged separately now

@cgwalters cgwalters enabled auto-merge (rebase) August 28, 2023 19:32
@cgwalters cgwalters merged commit 9b8ca32 into coreos:testing-devel Aug 28, 2023
@travier
Copy link
Member

travier commented Aug 29, 2023

  • Adding a new CI check without fixing the existing problems it finds (and also, trailing whitespace is not some kind of critical blocker)

I've added the whitespace check in #2563 and I fixed the whitespace errors that were in tree at the time. Maybe we merged something with whitespace errors right before we merge the new GitHub Action, which is exactly the point of the Action.

As I wrote in the commit:

While usually harmless, this can create issue in some edge cases and
creates noise when looking at the code in editors that highlight
unneeded whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants