fedora-coreos-base.yaml: nuke systemd-gpt-auto-generator #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, `systemd-gpt-auto-generator`'s generated `boot.automount` will cause a funky mount structure: ``` ├─/boot systemd-1 autofs │ └─/boot /dev/vda1 ext4 │ └─/boot/efi /dev/vda2 vfat ``` The nature of `autofs` then causes issues for us around shutdown ordering. See also the linked systemd issue. Really, we don't need the GPT generator at all for now, so just nuke it from the tree. Closes: coreos/fedora-coreos-tracker#215
ajeddeloh
approved these changes
Jul 17, 2019
| @@ -63,6 +63,10 @@ remove-from-packages: | |||
| /usr/lib/systemd/system/systemd-resolved.service, | |||
| /usr/lib/systemd/system/sysinit.target.wants/systemd-firstboot.service] | |||
|
|
|||
| # We don't want auto-generated mount units. See also | |||
| # https://github.com/systemd/systemd/issues/13099 | |||
| - [systemd-udev, /usr/lib/systemd/system-generators/systemd-gpt-auto-generator] | |||
There was a problem hiding this comment.
LGTM, but why are generators in the udev package?
There was a problem hiding this comment.
Not sure. Not all of them are in there, just a few.
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
This adds a FAQ entry explaining that Ignition and fcct configurations are different interfaces (not just JSON-vs-YAML for the same content).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
systemd-gpt-auto-generator's generatedboot.automountwill cause a funky mount structure:
The nature of
autofsthen causes issues for us around shutdownordering. See also the linked systemd issue.
Really, we don't need the GPT generator at all for now, so just nuke it
from the tree.
Closes: coreos/fedora-coreos-tracker#215