cmd-coreos-prune: Add build pruning after other actions #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Dec 11, 2024
src/cmd-coreos-prune
Outdated
| @@ -172,8 +172,7 @@ def main(): | |||
| prune_images(s3_client, current_build, images_to_keep, args.dry_run, bucket, prefix) | |||
| # Fully prune releases that are very old including deleting the directory in s3 for that build. | |||
| case "build": | |||
| prune_build(s3_client, bucket, prefix, build_id, args.dry_run) | |||
| pruned_build_ids.append(build_id) | |||
| builds_to_prune.append(build_id) | |||
There was a problem hiding this comment.
Suggested change
| builds_to_prune.append(build_id) | |
| # Since pruning a build prunes s3 for all architectures | |
| # we'll prune later so that we do it only once and we | |
| # make sure we've completed any architecture specific | |
| # operations, (i.e. pruning aarch64 AMIs). | |
| builds_to_prune.append(build_id) |
src/cmd-coreos-prune
Outdated
| @@ -112,7 +112,7 @@ def main(): | |||
| builds_json_data = json.load(f) | |||
| # Original list of builds | |||
| builds = builds_json_data["builds"] | |||
| pruned_build_ids = [] | |||
| builds_to_prune = [] | |||
There was a problem hiding this comment.
maybe we should make this a set so we can't add an entry more than once, which is what I think the below code will be doing.
There was a problem hiding this comment.
True that, updating.
We wanna make every other action is run before we prune a build fully and delete the s3 dir. It makes sure the meta.json is still available if needed.
gursewak1997
force-pushed
the
fix-builds-pruning-step
branch
from
831401d to
9e795a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to complete all other actions before fully pruning a build and deleting the S3 directory. This guarantees the
meta.jsonfile remains accessible if needed.