Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantle/platform/aws: handle missing details fields #3959

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 21, 2024

Possibly something changed on the AWS side, but we're seeing what looks like SnapshotTaskDetail structs coming back with some of the fields empty. Gracefully handle this case.

Possibly something changed on the AWS side, but we're seeing what looks
like `SnapshotTaskDetail` structs coming back with some of the fields
empty. Gracefully handle this case.
@aaradhak
Copy link
Member

I assume this code change is to log the status of the import task for debugging purpose.

@jlebon jlebon merged commit f3bef57 into coreos:main Nov 21, 2024
5 checks passed
@jlebon jlebon deleted the pr/aws-images-nil branch November 21, 2024 18:36
@jlebon
Copy link
Member Author

jlebon commented Nov 21, 2024

I assume this code change is to log the status of the import task for debugging purpose.

The main goal of the change is to check for nil pointers before dereferencing them.

@marmijo
Copy link
Member

marmijo commented Nov 21, 2024

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

@openshift-cherrypick-robot

@marmijo: new pull request created: #3960

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@marmijo: new pull request created: #3961

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@marmijo: new pull request created: #3962

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@marmijo: new pull request created: #3963

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@marmijo: new pull request created: #3964

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@marmijo: new pull request created: #3965

In response to this:

/cherrypick rhcos-4.17
/cherrypick rhcos-4.16
/cherrypick rhcos-4.15
/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marmijo
Copy link
Member

marmijo commented Nov 25, 2024

/cherrypick rhcos-4.18

@openshift-cherrypick-robot

@marmijo: new pull request created: #3971

In response to this:

/cherrypick rhcos-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants