Add cosa buildextend-layered
#3753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
jlebon
force-pushed
the
pr/buildextend-layered
branch
from
ee58a27 to
b685182
Compare
As part of openshift/os#799, we'll want to build the "OCP node" image as a layered image on top of the RHCOS base image. Eventually, this image should be built outside our pipelines and more like the rest of OpenShift container images. But for now, let's build it ourselves. This allows us to prove out the idea without yet requiring changes in the rest of OpenShift. The script added here looks wordy, but it's really trivial. It's basically a glorified wrapper around `podman build` and `skopeo copy` so that the built OCI image ends up in our `meta.json`.
jlebon
force-pushed
the
pr/buildextend-layered
branch
from
b685182 to
71dc812
Compare
|
OK, actually I think I've convinced myself we don't need this intermediate stage. Instead, I think it's better to just go straight to having a follow-on job that builds the image and pushes it to the registry. This makes immediately palpable the distinct phases between the base compose using our usual cosa pipeline vs the layered build, which is how we want it set up in the long run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of openshift/os#799, we'll want to
build the "OCP node" image as a layered image on top of the RHCOS base
image.
Eventually, this image should be built outside our pipelines and more
like the rest of OpenShift container images. But for now, let's build
it ourselves. This allows us to prove out the idea without yet requiring
changes in the rest of OpenShift.
The script added here looks wordy, but it's really trivial. It's
basically a glorified wrapper around
podman buildandskopeo copysothat the built OCI image ends up in our
meta.json.