cmd-build: add --versionary switch
#3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not cosa that decides what the version string will be, so it can't know that it'll be time-based. Refer instead to the manifest field, since that's the source of truth.
I'd like to move out the versionary script from this repo and into the FCOS source config repo. This is prep for adding a versionary script to openshift/os also and unlabeling the versionary knob in the pipeline as a hack.
|
One might wonder why not have cosa just always check if there's a versionary script in the source config and run it if present. The reason is that I do like that the default versioning scheme in FCOS is clearly identifiable as |
dustymabe
reviewed
Feb 20, 2024
| @@ -143,6 +148,12 @@ if [ $# -eq 0 ]; then | |||
| set -- qemu | |||
| fi | |||
|
|
|||
| if [ -z "${VERSION}" ] && [ -n "${VERSIONARY}" ]; then | |||
| # let error out if file does not exist | |||
There was a problem hiding this comment.
Suggested change
| # let error out if file does not exist | |
| # let's error out if file does not exist |
There was a problem hiding this comment.
It's more like, "let it error out if the file does not exist". I won't fix it to not ruin CI, but I'll queue it up for a future cosa PR.
dustymabe
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to move out the versionary script from this repo and into the
FCOS source config repo. This is prep for adding a versionary script to
openshift/os also and unlabeling the versionary knob in the pipeline as
a hack.