-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to f39 #3653
Update to f39 #3653
Conversation
Ah right yes, running headfirst into the grub2 thing for ppc... |
Today the ostree CI relies on the buildroot container, cosa and FCOS all being on the same major.
We will just have to stop testing ppc64le with PXE boot. HOWEVER: An important thing we could try to do going forward is again do a build of coreos-assembler using RHEL 9 (or CentOS Stream 9). We're not actually that far away from this last I tried, particularly using EPEL content.
It seems like jsonschema in Python 3.12 (in Fedora 39) changed some implementation details to now use a data structure that doesn't support deep copying: TypeError: cannot pickle 'rpds.HashTrieMap' object Instead of doing a deep copy, just create a new object from scratch with the same inputs. The `w` variable might've been for that; it's currently unused and is an exact copy of `m`.
OK cool, we got green CI here now! Edit: Ahh, Prow CI hasn't run yet since it was in draft mode. Definitely let's make sure RHCOS is happy first. |
Prow needs openshift/release#45710 to pass. |
Matches coreos/coreos-assembler#3653. While we're here, use the Quay.io image instead since that's the future.
The Fedora project is moving its images in Quay.io as being the official ones. Let's use it instead.
Matches coreos/coreos-assembler#3653. While we're here, use the Quay.io image instead since that's the future.
/retest |
Ohh fun. Looks like e2fsprogs 1.47 added a new feature that e2fsck in el9 can't handle. The fix for this of course is to use the Hmm, let me see if I can do some kind of feature detection. |
Fedora 39 has a newer e2fsprogs whose `mkfs.ext4` now turns on a new `orphan_file` feature by default. This feature is not supported by the `e2fsck` currently in RHEL 9. As mentioned in the comment, ideally we'd use the `mkfs.*` tools from the target system and not from cosa. But for now, just do some version testing to know when to opt out to avoid having to add another `image.yaml` knob for it. See: coreos#3653 (comment)
OK cool, CI is happy now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess maybe let's try to get this in soon so I can rebase #3654 |
Release done and Quay.io tag added! |
Update to f39
Today the ostree CI relies on the buildroot container, cosa and FCOS
all being on the same major.
build: Unfreeze grub2
We will just have to stop testing ppc64le with PXE boot.
HOWEVER: An important thing we could try to do going forward
is again do a build of coreos-assembler using RHEL 9 (or CentOS Stream 9).
We're not actually that far away from this last I tried, particularly
using EPEL content.