Refactor buildextend compression and add zip #3363
Conversation
|
Hi @baude. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
baude
force-pushed
the
zipcompression
branch
from
8185535
to
3a031d0
Compare
baude
force-pushed
the
zipcompression
branch
from
3a031d0
to
1c83d74
Compare
|
/ok-to-test |
baude
force-pushed
the
zipcompression
branch
2 times, most recently
from
c0eefde
to
e36e059
Compare
buildextend --compress supports gzip as an alternate compression over xz using a key called "gzip" where the value is a bool. This is now refactored to a key called "compression" with a value of "gzip", "skip", or "zip" (see below). The "skip-compression" key is no longer applicable. HyperV images which are used on Windows need to be compressed with zip because xz and gzip are not supported natively. Added zip support to buildextend and set the hyperv platform compression to "zip". Supports: * coreos/fedora-coreos-tracker#1411 * coreos/fedora-coreos-tracker#1424 Signed-off-by: Brent Baude <[email protected]>
|
Deferring merge until after Tuesday's releases, out of an abundance of caution. |
|
/retest |
buildextend --compress supports gzip as an alternate compression over xz using a key called "gzip" where the value is a bool. This is now refactored to a key called "compression" with a value of "gzip", "skip", or "zip" (see below). The "skip-compression" key is no longer applicable.
HyperV images which are used on Windows need to be compressed with zip because xz and gzip are not supported natively. Added zip support to buildextend and set the hyperv platform compression to "zip".
Supports:
* coreos/fedora-coreos-tracker#1411
* coreos/fedora-coreos-tracker#1421