cmdlib: consistently commit layers with same options #2703
Conversation
Make a helper for committing OSTree layers which contains all the canonicalization flags. Notably `--timestamp` which ensures that we get a consistent checksum for the same source git commit. Fixes: openshift/os#712 Fixes: coreos#2603
| echo -n "Committing ${tmp_overridesdir}/contentsetrootfs... " | ||
| ostree commit --repo="$tmprepo" --tree=dir="${tmp_overridesdir}"/contentsetrootfs -b contentset | ||
| commit_ostree_layer "${tmp_overridesdir}/contentsetrootfs" contentset |
There was a problem hiding this comment.
OK, and the bug was missing --timestamp here, which is why it only applies to RHCOS.
|
/retest |
|
rhcos failure is openshift/os#714 (comment) |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick rhcos-4.10 |
|
/cherrypick rhcos-4.10 |
|
@jlebon: new pull request created: #2706 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jlebon: new pull request could not be created: failed to create pull request against coreos/coreos-assembler#rhcos-4.10 from head openshift-cherrypick-robot:cherry-pick-2703-to-rhcos-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2703-to-rhcos-4.10."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make a helper for committing OSTree layers which contains all the
canonicalization flags. Notably
--timestampwhich ensures that we geta consistent checksum for the same source git commit.
Fixes: openshift/os#712
Fixes: #2603